-
Notifications
You must be signed in to change notification settings - Fork 439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BANDWIDTH / AVERAGE-BANDWIDTH #946 #1362
base: master
Are you sure you want to change the base?
Conversation
Hi @sannies, |
Hi @erankor , any comment on my code? Is it the correct approach? |
The numbers in BANDWIDTH and AVG_BANDWIDTH are now right with a single quality e.g.: TOS_,1000000,.mp4.urlset/master.m3u8 gives the right result The new (If anyone wants to chime in please do so otherwise this is a note to myself) |
I don't believe it's right what I'm doing here, but it works.
I now restrict the media_set via
and everything seems to work. I don't believe the approach is 100% right but I couldn't find a better way |
@erankor Hi, any comment? AMA! |
Hi @erankor,
I got a very early proof of concept here. It works for my single test file - not enough but a start.
The code that creates the i-frame playlist was transformed to compute segment sizes and (AVERAGE-)BANDWIDTH.
I believe I added a few too many things to the hls_master_request in ngx_http_vod_hls.c - that might introduce a performance penalty. But it's hard for me to understand which REQUEST and PARSE flags are actually required.
As I don't have a lot of experience with the plugin: Is this approach something you'd support?